On Mon, 13 Jan 2020, Mika Westerberg wrote: > The SCU IPC functionality is usable outside of Intel MID devices. For > example modern Intel CPUs include the same thing but now it is called > PMC (Power Management Controller) instead of SCU. To make the IPC > available for those split the driver into library part (intel_scu_ipc.c) > and the SCU PCI driver part (intel_scu_pcidrv.c) which then calls the > former before it goes and creates rest of the SCU devices. > > We also split the Kconfig symbols so that INTEL_SCU_IPC enables the SCU > IPC library and INTEL_SCU_PCI the SCU driver and convert the users > accordingly. While there remove default y from the INTEL_SCU_PCI symbol > as it is already selected by X86_INTEL_MID. > > Signed-off-by: Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx> > Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> > --- > arch/x86/Kconfig | 2 +- > arch/x86/include/asm/intel_scu_ipc.h | 14 +++++ > drivers/mfd/Kconfig | 4 +- For my own reference: Acked-for-MFD-by: Lee Jones <lee.jones@xxxxxxxxxx> > drivers/platform/x86/Kconfig | 26 ++++++--- > drivers/platform/x86/Makefile | 1 + > drivers/platform/x86/intel_scu_ipc.c | 75 +++++++++---------------- > drivers/platform/x86/intel_scu_pcidrv.c | 61 ++++++++++++++++++++ > 7 files changed, 122 insertions(+), 61 deletions(-) > create mode 100644 drivers/platform/x86/intel_scu_pcidrv.c [...] > diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig > index 420900852166..59515142438e 100644 > --- a/drivers/mfd/Kconfig > +++ b/drivers/mfd/Kconfig > @@ -593,7 +593,7 @@ config INTEL_SOC_PMIC_MRFLD > tristate "Support for Intel Merrifield Basin Cove PMIC" > depends on GPIOLIB > depends on ACPI > - depends on INTEL_SCU_IPC > + depends on INTEL_SCU > select MFD_CORE > select REGMAP_IRQ > help > @@ -625,7 +625,7 @@ config MFD_INTEL_LPSS_PCI > > config MFD_INTEL_MSIC > bool "Intel MSIC" > - depends on INTEL_SCU_IPC > + depends on INTEL_SCU > select MFD_CORE > help > Select this option to enable access to Intel MSIC (Avatele -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
