Thanks! Updated in v2. - Liming > -----Original Message----- > From: Andy Shevchenko <andy.shevchenko@xxxxxxxxx> > Sent: Friday, December 13, 2019 5:21 AM > To: Liming Sun <lsun@xxxxxxxxxxxx> > Cc: Andy Shevchenko <andy@xxxxxxxxxxxxx>; Darren Hart <dvhart@xxxxxxxxxxxxx>; Vadim Pasternak <vadimp@xxxxxxxxxxxx>; David > Woods <dwoods@xxxxxxxxxxxx>; Platform Driver <platform-driver-x86@xxxxxxxxxxxxxxx>; Linux Kernel Mailing List <linux- > kernel@xxxxxxxxxxxxxxx> > Subject: Re: [PATCH v1 1/1] platform/mellanox: fix the mlx-bootctl sysfs > > On Mon, Dec 9, 2019 at 9:24 PM Liming Sun <lsun@xxxxxxxxxxxx> wrote: > > > > This is a follow-up commit for the sysfs attributes to change > > from DRIVER_ATTR to DEVICE_ATTR according to some initial comments. > > In such case, it's better to point the sysfs path to the device > > itself instead of the driver. This commit adds the missing > > sysfs_create_group() so the attributes can be created under the > > device. The ABI document is also updated. > > > > Fixes tag, please. > > -- > With Best Regards, > Andy Shevchenko
