On Wed, Dec 4, 2019 at 12:46 PM Enrico Weigelt, metux IT consult <lkml@xxxxxxxxx> wrote: > > On 30.11.19 09:40, Matan Ziv-Av wrote: > > Add module version and fix a small whitespace discrepancy. > > > > Signed-off-by: Matan Ziv-Av <matan@xxxxxxxxxxx> > > --- > > drivers/platform/x86/lg-laptop.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/platform/x86/lg-laptop.c b/drivers/platform/x86/lg-laptop.c > > index c0bb1f864dfe..78d3e3d2e51a 100644 > > --- a/drivers/platform/x86/lg-laptop.c > > +++ b/drivers/platform/x86/lg-laptop.c > > @@ -26,6 +26,7 @@ > > MODULE_AUTHOR("Matan Ziv-Av"); > > MODULE_DESCRIPTION("LG WMI Hotkey Driver"); > > MODULE_LICENSE("GPL"); > > +MODULE_VERSION("1.1"); > > Does MODULE_VERSION() really make sense ? > What's the exact semantics behind those version numbers (in relation to > kernel version) - when do they get increased ? It makes no sense. The module version is equal to the kernel version (SHA ID in custom cases). -- With Best Regards, Andy Shevchenko