On Mon, Nov 4, 2019 at 11:39 PM Leonid Maksymchuk <leonmaxx@xxxxxxxxx> wrote: > > Set default fan boost mode to normal for multiple reasons: > > 1) existing code assumes that laptop started in normal mode and that is > not always correct. > 2) FX705DY/FX505DY starts in silent mode and under heavy CPU load it > overheats and drops CPU frequency to 399MHz [1]. Setting fan mode to > normal avoids overheating. > > [1] Link: https://bugzilla.kernel.org/show_bug.cgi?id=203733 > > Signed-off-by: Leonid Maksymchuk <leonmaxx@xxxxxxxxx> > +static int fan_boost_mode_set_default(struct asus_wmi *asus) > +{ > + int result = 0; > + > + if (asus->fan_boost_mode_available) { > + asus->fan_boost_mode = ASUS_FAN_BOOST_MODE_NORMAL; > + result = fan_boost_mode_write(asus); > + } > + > + return result; > +} This can be refactored if (!foo) return 0; ... return bar(asus); -- With Best Regards, Andy Shevchenko
