Re: [PATCH] platform/x86: Add Lenovo ThinkPad PrivacyGuard.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Oct 25, 2019 at 2:33 PM Pali Rohár <pali.rohar@xxxxxxxxx> wrote:
> On Thursday 22 August 2019 13:48:33 Alexander Schremmer wrote:
> > This feature is found optionally in T480s, T490, T490s.
> >
> > The feature is called lcdshadow and visible via
> > /proc/acpi/ibm/lcdshadow.
> >
> > The ACPI methods \_SB.PCI0.LPCB.EC.HKEY.{GSSS,SSSS,TSSS,CSSS} are
> > available in these machines. They get, set, toggle or change the state
> > apparently.
> >
> > The patch was tested on a 5.0 series kernel on a T480s.

> > +     echo '0' >/proc/acpi/ibm/lcdshadow
> > +     echo '1' >/proc/acpi/ibm/lcdshadow

> Hello! Is not the whole /proc/apci/ibm API for new things obsoleted or deprecated?
> And should not rather it use platform driver in /sys/ (class?) namespace?

There is an ongoing discussion about API to this kind of devices
somewhere in GPU mailing lists.
This interface is custom and probably shall never have been appeared.
However no-one prevented this from happening.

-- 
With Best Regards,
Andy Shevchenko




[Index of Archives]     [Linux Kernel Development]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux