On Fri, Oct 11, 2019 at 04:07:17PM -0700, Dmitry Torokhov wrote:
> We do not need a special flag to know if we are dealing with an array,
> as we can get that data from ratio between element length and the data
> size, however we do need a flag to know whether the data is stored
> directly inside property_entry or separately.
> - if (prop->is_array)
> + if (!prop->is_inline)
> - if (p->is_array) {
> + if (!p->is_inline) {
> - if (src->is_array) {
> + if (!src->is_inline) {
May we have positive conditionals instead?
> + * @is_inline: True when the property value is stored directly in
I think word 'directly' is superfluous here.
Or, perhaps, 'stored directly' -> 'embedded'
> + * &struct property_entry instance.
> + * @pointer: Pointer to the property when it is stored separately from
> + * the &struct property_entry instance.
'separately from' -> 'outside' ?
> + * @value: Value of the property when it is stored inline.
'stored inline' -> 'embedded in the &struct...' ?
--
With Best Regards,
Andy Shevchenko
