On Fri, Oct 11, 2019 at 05:47:12PM +0300, Andy Shevchenko wrote:
> For APIC case of interrupt we don't fail a ->probe() of the driver,
> which makes kernel to print a lot of warnings from the children.
>
> We have two options here:
> - switch to platform_get_irq_optional(), though it won't stop children
> to be probed and failed
> - fail the ->probe() of i2c-multi-instantiate
>
> Since the in reality we never had devices in the wild where IRQ resource
> is optional, the latter solution suits the best.
>
> Fixes: 799d3379a672 ("platform/x86: i2c-multi-instantiate: Introduce IOAPIC IRQ support")
> Cc: Heikki Krogerus <heikki.krogerus@xxxxxxxxxxxxxxx>
> Cc: Hans de Goede <hdegoede@xxxxxxxxxx>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
Reviewed-by: Heikki Krogerus <heikki.krogerus@xxxxxxxxxxxxxxx>
> ---
> drivers/platform/x86/i2c-multi-instantiate.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/platform/x86/i2c-multi-instantiate.c b/drivers/platform/x86/i2c-multi-instantiate.c
> index ea68f6ed66ae..ffb8d5d1eb5f 100644
> --- a/drivers/platform/x86/i2c-multi-instantiate.c
> +++ b/drivers/platform/x86/i2c-multi-instantiate.c
> @@ -108,6 +108,7 @@ static int i2c_multi_inst_probe(struct platform_device *pdev)
> if (ret < 0) {
> dev_dbg(dev, "Error requesting irq at index %d: %d\n",
> inst_data[i].irq_idx, ret);
> + goto error;
> }
> board_info.irq = ret;
> break;
> --
> 2.23.0
thanks,
--
heikki
