Hi Hans, On Fri, Aug 16, 2019 at 11:18 AM Hans de Goede <hdegoede@xxxxxxxxxx> wrote: > So I've just tested this on a Cherry Trail machine and > the interrupt storm, fixing which is the reason the > intel_int0002_vgpio.c driver was introduced, is back: Sorry but just so I understand this report: when you say the interrupt storm is back, do you mean that this patch brings it back, or do you mean the interrupt storm is there even before this patch? This patch does bring semantic differences, but very small ones. > Notice that the driver has attached itself as shared irq-handler > to the ACPI IRQ What is it sharing it with? > Do I need any patches on top of 5.3-rc4 to test this patch? No, none that I know of. It is weird that this driver registers a chained interrupt handler but int0002_irq() doesn't call chained_irq_[enter|exit]. I don't understand the ACPI code but I'm confused about a "virtual" GPIO controller with very real interrupt lines attached to it. If it is actually virtual then just trying to abuse gpiolib to cascade interrupts like the shared interrupts were some, you know, cascaded GPIO IRQ line, I guess all the consumers should just grab the interrupt independently and shared instead, the idea being that each of them will drop their pull of the shared level IRQ line until it is eventually deasserted. I'm just confused.... Yours, Linus Walleij
