Re: [PATCH 2/3] platform/x86/pcengines-apuv2: add legacy leds gpio definitions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2019-07-08 21:42, Enrico Weigelt, metux IT consult wrote:
On 04.07.19 11:02, Florian Eckert wrote:
Extend the apu2_leds definition to make the leds exportable via the
legacy gpio subsystem.

What for ? The gpios are bound to LED devices as that's exactly what
they are: LEDs.

I have back ported your pcengines-apuv2 device and gpio-amd-fch GPIO driver to the kernel version 4.19 on OpenWrt. If I compile and load this without the change no LEDs are visible in "/sys/class/leds"!

From my point of view the connection between the GPIO and the LEDs subsystem is missing.
How should the LED subsystem know which GPIO to use?
If I add the change to the pcengines-apuv2 device then the LEDs will be visilbe under "/sys/class/leds"
and could be used, by OpenWrt userland.

Mybe I miss something.



[Index of Archives]     [Linux Kernel Development]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux