On Thu, Jul 4, 2019 at 5:00 PM Florian Eckert <fe@xxxxxxxxxx> wrote: > > Hello Andy, > > thanks for feedback > > >> This patchset adds the following changes to this pcengines-apuv2 > >> platform device. > >> > > > > Before doing anything to this driver, what is the plan for previously > > upstreamed: > > > > drivers/leds/leds-apu.c > > I think we can remove the related APU2/APU3 code stuff from this driver. > The recently added pcengines-apuv2 driver does *not* support the APU1. > So I think we need the related APU1 stuff if we still want to support > this board. So, I would like to see some unification (since it's material for v5.4 cycle anyway, we have time). > > arch/x86/platform/geode/alix.c > > I think this is not related because this is a different platform driver. > Maybe we should move them to drivers/platform/x86? You mentioned somewhere ALIx, can you elaborate if these are platforms of the same family (PC engines)? Looking into the code, I think we may unify all three under umbrella of one driver if the above is true. -- With Best Regards, Andy Shevchenko
