Re: [PATCH 1/2] x86/platform/intel-mid: Create pinctrl platform device at later initcall

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jun 12, 2019 at 11:21 AM Jarkko Nikula
<jarkko.nikula@xxxxxxxxxxxxxxx> wrote:
> On 6/11/19 3:58 PM, Andy Shevchenko wrote:
> >> Andy: I'm not sure is this with the next patch the right fix or would it be
> >> possible to just delete this "pinctrl-merrifield" initialization filei? I
> >> went to this path since I don't know are there platforms without
> >> "INTC1002" in their ACPI tables or do some users want to run non-ACPI
> >> kernels.
> >
> > I have locally one hack with another approach, i.e. check for SFI
> > availability like the rest of the files in this folder works, with few
> > exceptions as this one.
> >
> > So, something like
> >
> > if (sfi_disabled)
> >    return -EINVAL.
> >
> > If you have time, you can split and submit the
> > https://github.com/andy-shev/linux/commit/7a0cb10387a437f5811435b9c790043c64816d08
> >
> Seems to accomplish the same.

Yes.

> Are you planning to send it out

At some point. There is more important things to push first (make USB
OTG work on vanilla).
That's why I asked if you have time. The mentioned change should be
simple split and commit message massaged.

> and do you
> think are my patches needed after it? If you think they are needed I can
> rebase my patches on top of yours and resend.

I don't think they will be needed.

-- 
With Best Regards,
Andy Shevchenko



[Index of Archives]     [Linux Kernel Development]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux