On Fri, May 17, 2019 at 01:49:05PM -0400, Liming Sun wrote: > This commit adds the ABI definitions exposed to userspace for > the platform/mellanox/mlxbf-bootctl driver. > > Reviewed-by: Vadim Pasternak <vadimp@xxxxxxxxxxxx> > Signed-off-by: Liming Sun <lsun@xxxxxxxxxxxx> > --- > .../ABI/testing/sysfs-platform-mellanox-bootctl | 58 ++++++++++++++++++++++ > MAINTAINERS | 1 + > 2 files changed, 59 insertions(+) > create mode 100644 Documentation/ABI/testing/sysfs-platform-mellanox-bootctl > > diff --git a/Documentation/ABI/testing/sysfs-platform-mellanox-bootctl b/Documentation/ABI/testing/sysfs-platform-mellanox-bootctl > new file mode 100644 > index 0000000..19a14db > --- /dev/null > +++ b/Documentation/ABI/testing/sysfs-platform-mellanox-bootctl > @@ -0,0 +1,58 @@ > +What: /sys/bus/platform/drivers/mlxbf-bootctl/lifecycle_state > +Date: May 2019 > +KernelVersion: 5.3 > +Contact: "Liming Sun <lsun@xxxxxxxxxxxx>" > +Description: > + The Life-cycle state of the SoC, which could be one of the > + following values. > + Production - Production state and can be updated to secure > + GA Secured - Secure chip and not able to change state > + GA Non-Secured - Non-Secure chip and not able to change state > + RMA - Return Merchandise Authorization A "driver" does not have a lifecycle state, a "device" does. You are putting all of these attributes in the wrong place. Put them on your device please, not the driver. driver-specific attributes are _VERY_ rare, and only for things that can modify/show for all devices attached to that driver. thanks, greg k-h
