On Thu, May 9, 2019 at 8:49 PM Yurii Pavlovskyi <yurii.pavlovskyi@xxxxxxxxx> wrote: > On 08.05.19 15:58, Andy Shevchenko wrote: > Yes, looking at this patch now I'd guess the refactoring there is really > misguided as it adds a lot more code than it removes, will drop it > completely and just add a new condition to the current check instead in > next version: > - /* If value is zero, something is clearly wrong */ > - if (!value) > + if (!value || value == 1) Perhaps here makes sense to explicitly show value == 0. -- With Best Regards, Andy Shevchenko
