From: Andy Shevchenko <andy.shevchenko@xxxxxxxxx> Date: Wed, May 8, 2019 at 2:22 PM To: Randy Dunlap Cc: Stephen Rothwell, Linux Next Mailing List, Linux Kernel Mailing List, Rajat Jain, Platform Driver, Rajneesh Bhardwaj, Vishwanath Somayaji > On Wed, May 8, 2019 at 11:45 PM Randy Dunlap <rdunlap@xxxxxxxxxxxxx> wrote: > > > > On 5/8/19 12:34 AM, Stephen Rothwell wrote: > > > Hi all, > > > > > > Changes since 20190507: > > > > > > The ubifs tree gained a conflict against Linus' tree. > > > > > > > on i386 or x86_64: > > Thank you for report. Can you provide what is the config option for > this module? I suppose it's built-in. > Rajat, I will drop this from the repo, because I don't see it would > have a chance to be tested in time. OK, NP. Just to be sure I understand, 1) Please let me know if I should send in a fix (it would be #include/linux/module.h and also add MODULE_LICENSE() I believe)? 2) Would this be lined up for next version though? Thanks, Rajat > > > > > > > > CC drivers/platform/x86/intel_pmc_core_plat_drv.o > > ../drivers/platform/x86/intel_pmc_core_plat_drv.c:40:1: warning: data definition has no type or storage class [enabled by default] > > MODULE_DEVICE_TABLE(x86cpu, intel_pmc_core_platform_ids); > > ^ > > ../drivers/platform/x86/intel_pmc_core_plat_drv.c:40:1: error: type defaults to ‘int’ in declaration of ‘MODULE_DEVICE_TABLE’ [-Werror=implicit-int] > > ../drivers/platform/x86/intel_pmc_core_plat_drv.c:40:1: warning: parameter names (without types) in function declaration [enabled by default] > > ../drivers/platform/x86/intel_pmc_core_plat_drv.c:59:1: warning: data definition has no type or storage class [enabled by default] > > module_init(pmc_core_platform_init); > > ^ > > ../drivers/platform/x86/intel_pmc_core_plat_drv.c:59:1: error: type defaults to ‘int’ in declaration of ‘module_init’ [-Werror=implicit-int] > > ../drivers/platform/x86/intel_pmc_core_plat_drv.c:59:1: warning: parameter names (without types) in function declaration [enabled by default] > > ../drivers/platform/x86/intel_pmc_core_plat_drv.c:60:1: warning: data definition has no type or storage class [enabled by default] > > module_exit(pmc_core_platform_exit); > > ^ > > ../drivers/platform/x86/intel_pmc_core_plat_drv.c:60:1: error: type defaults to ‘int’ in declaration of ‘module_exit’ [-Werror=implicit-int] > > ../drivers/platform/x86/intel_pmc_core_plat_drv.c:60:1: warning: parameter names (without types) in function declaration [enabled by default] > > ../drivers/platform/x86/intel_pmc_core_plat_drv.c:42:19: warning: ‘pmc_core_platform_init’ defined but not used [-Wunused-function] > > static int __init pmc_core_platform_init(void) > > ^ > > > > and > > WARNING: modpost: missing MODULE_LICENSE() in drivers/platform/x86/intel_pmc_core_plat_drv.o > > > > -- > > ~Randy > > > > -- > With Best Regards, > Andy Shevchenko
