On Wed, May 1, 2019 at 11:44 PM Gustavo A. R. Silva <gustavo@xxxxxxxxxxxxxx> wrote: > > > > On 4/24/19 7:55 PM, ibm-acpi@xxxxxxxxxx wrote: > > On Wed, Apr 24, 2019, at 16:05, Kees Cook wrote: > >> On Wed, Apr 24, 2019 at 11:15 AM Gustavo A. R. Silva > >> <gustavo@xxxxxxxxxxxxxx> wrote: > >>> > >>> In preparation to enabling -Wimplicit-fallthrough, mark switch > >>> cases where we are expecting to fall through. > >>> > >>> This patch fixes the following warnings: > >>> > > [..] > > >>> > >>> Warning level 3 was used: -Wimplicit-fallthrough=3 > >>> > >>> Notice that, in this particular case, the code comments are modified > >>> in accordance with what GCC is expecting to find. > >>> > >>> This patch is part of the ongoing efforts to enable > >>> -Wimplicit-fallthrough. > >>> > >>> Signed-off-by: Gustavo A. R. Silva <gustavo@xxxxxxxxxxxxxx> > >> > >> Reviewed-by: Kees Cook <keescook@xxxxxxxxxxxx> > > > > Acked-by: Henrique de Moraes Holschuh <hmh@xxxxxxxxxx> > > > > Thank you both, Kees and Henrique. > > Friendly ping: > > Who can take this? Pushed to my review and testing queue, thanks! > > Thanks > -- > Gustavo -- With Best Regards, Andy Shevchenko
