On 09.04.19 20:20, Jacek Anaszewski wrote: >> Pavel, Jacek, we got a duplicate driver for some devices here, the old>> one was submited couple of years ago and went to upstream thru LED>> subsystem.>> What would be your recommendation on this case?> > Remove that recent duplicate? It's not duplicate, it's more complete. The old driver is just for LEDs on apu board, and blocks all the others pins, eg. front key. OTOH, the new drivers are: #1: generic gpio driver for the amd-fch (at least generic for all G-112* boards, probably for lots of other SoCs w/ the same FCH) #2: minimal platform driver that wires up gpios to led and input subsystems, so it provides leds as well as front key. They now provide full support for the APU2/3 front peripherals, LEDs as well as front key. The key cannot be used w/ the old led-only driver. --mtx -- Enrico Weigelt, metux IT consult Free software and Linux embedded engineering info@xxxxxxxxx -- +49-151-27565287