On Thu, Apr 11, 2019 at 4:21 AM Yurii Pavlovskyi <yurii.pavlovskyi@xxxxxxxxx> wrote: > > The asus-wmi driver does not clean up the hwmon device on exit or error. > To reproduce the bug, repeat rmmod, insmod to verify that device number > /sys/devices/platform/asus-nb-wmi/hwmon/hwmon?? grows every time. Add > pointer to the device in module state and call cleanup on error. I wonder if this can be fixed more cleanly by using devm_hwmon_device_register_with_groups() ? Thanks Daniel