Re: [PATCH v1 4/4] platform/x86: intel_punit_ipc: Revert "Fix resource ioremap warning"

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On 4/9/19 4:25 AM, Andy Shevchenko wrote:
Since we have a proper fix for intel_pmc_ipc driver for resource management,
get rid of unneeded commit in the intel_punit_ipc driver.

This reverts commit 6cc8cbbc8868033f279b63e98b26b75eaa0006ab.
Reviewed-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@xxxxxxxxxxxxxxx>

Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
---
  drivers/platform/x86/intel_punit_ipc.c | 8 ++++----
  1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/platform/x86/intel_punit_ipc.c b/drivers/platform/x86/intel_punit_ipc.c
index 79671927f4ef..ab7ae1950867 100644
--- a/drivers/platform/x86/intel_punit_ipc.c
+++ b/drivers/platform/x86/intel_punit_ipc.c
@@ -252,28 +252,28 @@ static int intel_punit_get_bars(struct platform_device *pdev)
  	 * - GTDRIVER_IPC BASE_IFACE
  	 */
  	res = platform_get_resource(pdev, IORESOURCE_MEM, 2);
-	if (res && resource_size(res) > 1) {
+	if (res) {
  		addr = devm_ioremap_resource(&pdev->dev, res);
  		if (!IS_ERR(addr))
  			punit_ipcdev->base[ISPDRIVER_IPC][BASE_DATA] = addr;
  	}
res = platform_get_resource(pdev, IORESOURCE_MEM, 3);
-	if (res && resource_size(res) > 1) {
+	if (res) {
  		addr = devm_ioremap_resource(&pdev->dev, res);
  		if (!IS_ERR(addr))
  			punit_ipcdev->base[ISPDRIVER_IPC][BASE_IFACE] = addr;
  	}
res = platform_get_resource(pdev, IORESOURCE_MEM, 4);
-	if (res && resource_size(res) > 1) {
+	if (res) {
  		addr = devm_ioremap_resource(&pdev->dev, res);
  		if (!IS_ERR(addr))
  			punit_ipcdev->base[GTDRIVER_IPC][BASE_DATA] = addr;
  	}
res = platform_get_resource(pdev, IORESOURCE_MEM, 5);
-	if (res && resource_size(res) > 1) {
+	if (res) {
  		addr = devm_ioremap_resource(&pdev->dev, res);
  		if (!IS_ERR(addr))
  			punit_ipcdev->base[GTDRIVER_IPC][BASE_IFACE] = addr;

--
Sathyanarayanan Kuppuswamy
Linux kernel developer




[Index of Archives]     [Linux Kernel Development]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux