On 4/10/19 6:59 AM, Andy Shevchenko wrote:
On Tue, Apr 09, 2019 at 08:39:39PM +0300, Andy Shevchenko wrote:
On Tue, Apr 09, 2019 at 10:07:35AM -0700, sathyanarayanan kuppuswamy wrote:
On 4/9/19 4:25 AM, Andy Shevchenko wrote:
Use BIT() and BIT_MASK() macros for definitions.
Looks good to me.
Thanks!
If you have no further comments, can you provide your tag here?
Reviewed-by: Kuppuswamy Sathyanarayanan
<sathyanarayanan.kuppuswamy@xxxxxxxxxxxxxxx>
/* PMC register bit definitions */
/* PMC_CFG_REG bit masks */
-#define PMC_CFG_NO_REBOOT_MASK (1 << 4)
+#define PMC_CFG_NO_REBOOT_MASK BIT_MASK(4)
#define PMC_CFG_NO_REBOOT_EN (1 << 4)
#define PMC_CFG_NO_REBOOT_DIS (0 << 4)
Do we need 0 << 4 ?
Yes, to explicitly show that this is a value for NO_REBOOT masked bit(s)
(single bit in this case).
--
With Best Regards,
Andy Shevchenko
--
Sathyanarayanan Kuppuswamy
Linux kernel developer
