On Thu, Apr 4, 2019 at 5:14 PM David Müller <dave.mueller@xxxxxx> wrote:
>
> Since commit 648e921888ad ("clk: x86: Stop marking clocks as
> CLK_IS_CRITICAL"), the pmc_plt_clocks of the Bay Trail SoC are
> unconditionally gated off. Unfortunately this will break systems where these
> clocks are used for external purposes beyond the kernel's knowledge. Fix it
> by implementing a system specific quirk to mark the necessary pmc_plt_clks
> as critical.
>
> Fixes: 648e921888ad ("clk: x86: Stop marking clocks as CLK_IS_CRITICAL")
> Signed-off-by: David Müller <dave.mueller@xxxxxx>
I'm fine with the patch, though few minor comments below.
> + /*
> + * On some systems, the pmc_plt_clocks already enabled by the
> + * firmware are being marked as critical to avoid them being
> + * gated by the clock framework
Period would be nice to have at the end.
> + */
> + if (d) {
> + clk_data->chk_critclks = true;
> + pr_info("%s critclks quirk enabled\n", d->ident);
> + }
I would go with callback, but for now this is okay as well.
> - * @base: PMC clock register base offset
> - * @clks: pointer to set of registered clocks, typically 0..5
> + * @base: PMC clock register base offset
> + * @clks: pointer to set of registered clocks, typically 0..5
> + * @chk_critclks: flag to indicate if firmware enabled pmc_plt_clks
> + * should be marked as critial or not
Perhaps simple critical? And do not touch the rest here.
> */
--
With Best Regards,
Andy Shevchenko
