Re: [PATCH] platform/x86: intel_pmc_ipc: adding error handling

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Mar 27, 2019 at 5:10 AM <junxiao.chang@xxxxxxxxx> wrote:
>
> From: Junxiao Chang <junxiao.chang@xxxxxxxxx>
>
> If punit or telemetry device initialization fails, pmc driver should
> unregister and return failure.
>
> This change is to fix a kernel panic when removing kernel module
> intel_pmc_ipc.

Can you provide a Fixes tag?

>
> Signed-off-by: Junxiao Chang <junxiao.chang@xxxxxxxxx>
> ---
>  drivers/platform/x86/intel_pmc_ipc.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/platform/x86/intel_pmc_ipc.c b/drivers/platform/x86/intel_pmc_ipc.c
> index ffe0cac..c6d09ad 100644
> --- a/drivers/platform/x86/intel_pmc_ipc.c
> +++ b/drivers/platform/x86/intel_pmc_ipc.c
> @@ -789,13 +789,17 @@ static int ipc_create_pmc_devices(void)
>         if (ret) {
>                 dev_err(ipcdev.dev, "Failed to add punit platform device\n");
>                 platform_device_unregister(ipcdev.tco_dev);
> +               return ret;
>         }
>
>         if (!ipcdev.telem_res_inval) {
>                 ret = ipc_create_telemetry_device();
> -               if (ret)
> +               if (ret) {
>                         dev_warn(ipcdev.dev,
>                                 "Failed to add telemetry platform device\n");
> +                       platform_device_unregister(ipcdev.punit_dev);
> +                       platform_device_unregister(ipcdev.tco_dev);
> +               }
>         }
>
>         return ret;
> --
> 2.7.4
>


-- 
With Best Regards,
Andy Shevchenko



[Index of Archives]     [Linux Kernel Development]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux