Re: [PATCH v2] clk: x86: Add system specific quirk to mark clocks as critical

[David Müller <dave.mueller@xxxxxx>]

Hello

Thanks for the review.

Hans de Goede wrote:
>> +/*
>> + * Some systems need one or more of their pmc_plt_clks to be
>> + * marked as critical
>> + */
>> +static const struct dmi_system_id critclk_systems[] __initconst = {
>> +    {
>> +        .ident = "MPL CEC1x",
>> +        .matches = {
>> +            DMI_MATCH(DMI_SYS_VENDOR, "MPL AG"),
>> +            DMI_MATCH(DMI_PRODUCT_NAME, "CEC10 Family"),
>> +        },
>> +    },
>
> You need an empty terminating entry here, otherwise the dmi functions
> will keep walking the array, so you need to add:
>
>     {}
>
> here.

Arrgh, shame on me.

Is there a rule / recommendation how the sentinel entry should look
like? In the kernel sources I see a "{}", "{ }", "{ /*sentinel*/ }", ...


Dave