On Sun, Feb 10, 2019 at 3:36 PM htrovao <htrovao@xxxxxxxxx> wrote: > > Hi, > > added Lenovo Yoga C930 to ideapad_laptop no_hw_rfkill_list. > > Lenovo Yoga C930 does not have a physical hw radio switch which makes ideapad_laptop to incorrectly disable radio while it should be working fine. > > Adding it to the no_hw_rfkill_list makes wireless available again without having to unload the module. This patch is similar to other models with same issue like lenovo yoga 2. > > (the entry is alphabetically sorted like suggested in other similar patch: https://lore.kernel.org/patchwork/patch/565743/) > > It was tested successfully on fedora29 base kernel 4.20.7 with a Lenovo Yoga C930-13IKB. > > This is my first submission for kernel patch, hope everything is alright and submitting to the rigth place. Please tell if any problem. Thanks. Thanks for the patch. Unfortunately it has few errors that prevent us to apply it: - the message doesn't have our mailing list in the Cc, i.e. Platform Driver <platform-driver-x86@xxxxxxxxxxxxxxx> - the message is not formatted properly (usually ~72 characters per line) - the patch has no Signed-off-by tag which is a show stopper - the patch itself isn't formed using standard tools, i.e. git format-patch & git send-email Please, address above comments and send it properly. > > Best regards, > htrovao > > > --- > drivers/platform/x86/ideapad-laptop.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/drivers/platform/x86/ideapad-laptop.c b/drivers/platform/x86/ideapad-laptop.c > index b6489cba2985..2f6169123de2 100644 > --- a/drivers/platform/x86/ideapad-laptop.c > +++ b/drivers/platform/x86/ideapad-laptop.c > @@ -1237,6 +1237,13 @@ static const struct dmi_system_id no_hw_rfkill_list[] = { > DMI_MATCH(DMI_PRODUCT_VERSION, "Lenovo YOGA 920-13IKB"), > }, > }, > + { > + .ident = "Lenovo YOGA C930-13IKB", > + .matches = { > + DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"), > + DMI_MATCH(DMI_PRODUCT_VERSION, "Lenovo YOGA C930-13IKB"), > + }, > + }, > { > .ident = "Lenovo Zhaoyang E42-80", > .matches = { > -- > 2.20.1 > -- With Best Regards, Andy Shevchenko
