On Tue, Feb 12, 2019 at 12:16 PM Ard Biesheuvel <ard.biesheuvel@xxxxxxxxxx> wrote: > On Tue, 12 Feb 2019 at 11:09, Anders Roxell <anders.roxell@xxxxxxxxxx> wrote: > > > > Commit a893ea15d764 ("tpm: move tpm_chip definition to > > include/linux/tpm.h") introduced a build error when both ima and efi is > > enabled. What happens is that both headers (ima.h and efi.h) defines the > > same 'NONE' constant, and it broke when they started getting included > > from the same file. > I'd argue that we should apply both patches. 'NONE' is far too > generic, so it requires a subsystem prefix if it has a special meaning > inside a subsystem. I was about to say the same thing. -- With Best Regards, Andy Shevchenko