On Sat, Feb 2, 2019 at 4:41 PM Mark Levedahl <mlevedahl@xxxxxxxxx> wrote: > > Commit 0252894f53fc2693672308 added the Legion Y530 to the no_hw_rfkill list, but missed a > > Y530 variant using the nvidia 1060 graphics card. I have had to blacklist ideapad-laptop > > as a result to get wifi working. Wi-Fi > > dmidecode info: > > Handle 0x0001, DMI type 1, 27 bytes > System Information > Manufacturer: LENOVO > Product Name: 81LB > Version: Lenovo Legion Y530-15ICH-1060 > Serial Number: <snip> > UUID: <snip> > Wake-up Type: Power Switch > SKU Number: LENOVO_MT_81LB_BU_idea_FM_Legion Y530-15ICH-1060 > Family: Legion Y530-15ICH-1060 > > The "obvious" patch is: Redundant. Please, use corresponding tools to format and send patches, i.e. git format-patch and git send-email. Currently patch contents are mangled and can't be applied. Besides that it has no mandatory tags [1], i.e. Signed-off-by, which prevents me apply even if I fix it manually. [1]: Documentation/process/submitting-patches.rst (chapter 11 is a point of interest) Please, fix all above and resend. Don't forget to increment a version and append a changelog. > > diff --git a/drivers/platform/x86/ideapad-laptop.c b/drivers/platform/x86/ideapad-laptop.c > index 1589dffab9fa..4ecb2340cd07 100644 > --- a/drivers/platform/x86/ideapad-laptop.c > +++ b/drivers/platform/x86/ideapad-laptop.c > @@ -1153,6 +1153,13 @@ static const struct dmi_system_id no_hw_rfkill_list[] = { > DMI_MATCH(DMI_PRODUCT_VERSION, "Lenovo Legion Y530-15ICH"), > }, > }, > + { > + .ident = "Lenovo Legion Y530-15ICH-1060", > + .matches = { > + DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"), > + DMI_MATCH(DMI_PRODUCT_VERSION, "Lenovo Legion Y530-15ICH-1060"), > + }, > + }, > { > .ident = "Lenovo Legion Y720-15IKB", > .matches = { > -- > -- With Best Regards, Andy Shevchenko