On Mon, Dec 10, 2018 at 8:20 AM Gert Robben <t2@xxxxxxx> wrote:
>
> Op 09-12-18 om 18:28 schreef Dan Williams:
> > On Sun, Dec 9, 2018 at 7:25 AM Andy Shevchenko
> > <andy.shevchenko@xxxxxxxxx> wrote:
> >>
> >> Cc: Dan (Dan, it seems in the file mentioned in the bug the only
> >> change between affected and non-affected verions is yours)
> >>
> >> Thanks for the report!
> >
> > Thanks for forwarding, can you give the attached patch a try to get
> > more information?
> >
> > We should remove the BUG_ON() regardless of the outcome,
> > reserve_memtype() failures should not bring down the system.
>
> In the meantime, I learned to bisect, and found the problem commit:
> 510ee090abc3dbc862bd35f5f3d8b7284a9117b4
> "x86/mm/pat: Prepare {reserve, free}_memtype() for "decoy" addresses"
> Perhaps you already knew that, but FWIW.
Thanks! That's the commit I referenced to when added Dan to Cc list.
>
> As I'm new to Git, you might want to check how I checked:
> git checkout 510ee090abc3dbc862bd35f5f3d8b7284a9117b4
> Build, boot, I get the BUG.
>
> Apply your debug patch, build, boot, and in dmesg can be seen:
> reserve_memtype failed [mem 0xffff0000-0xffffffff], [s_mem 0xffff
> 0000-0xffffffffffffffff], type: uncached-minus
> ioremap reserve_memtype failed -22
> net5501: failed to get rombase
>
> (first revert debug patch, then)
> git revert 510ee090abc3dbc862bd35f5f3d8b7284a9117b4
> Build, boot, it works.
> Those 3 lines in dmesg are gone, the rest of the lines are the same.
>
> Thanks,
> Gert
--
With Best Regards,
Andy Shevchenko
