On Mon, Dec 3, 2018 at 4:22 PM Takashi Iwai <tiwai@xxxxxxx> wrote:
> On Mon, 03 Dec 2018 15:18:54 +0100,
> Andy Shevchenko wrote:
> >
> > On Mon, Dec 3, 2018 at 2:00 PM Takashi Iwai <tiwai@xxxxxxx> wrote:
> > > On Fri, 30 Nov 2018 00:57:37 +0100,
> > > Ayman Bagabas wrote:
> >
> > > > +struct huawei_wmi_priv {
> > > > + struct input_dev *idev;
> > > > + struct led_classdev cdev;
> > > > + acpi_handle handle;
> > >
> > > Is this handle set in anywhere? I couldn't see it in your patch.
> > > If it's supposed to be NULL, passing NULL explicitly makes your
> > > intention clearer.
> >
> > Isn't below an answer?
> >
> > > > + // Skip registering LED subsystem if no ACPI method was found.
> > > > + status = acpi_get_handle(priv->handle, "\\_SB.PCI0.LPCB.EC0", &priv->handle);
>
> Oh indeed, but why it passes priv->handle at the first argument...?
Yes, since it's an absolute, I guess NULL in this case will be OK.
--
With Best Regards,
Andy Shevchenko
