Re: [PATCH 0/6] Introduce audio-mute LED trigger (and conversions to it)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 28 Nov 2018 13:25:05 +0100,
Pavel Machek wrote:
> 
> On Wed 2018-11-28 12:38:19, Takashi Iwai wrote:
> > On Wed, 28 Nov 2018 12:18:06 +0100,
> > Pali Rohár wrote:
> > > 
> > > On Tuesday 27 November 2018 09:44:18 Pavel Machek wrote:
> > > > Looks good... except one detail: you have "tpacpi::micmute" and
> > > > "dell::micmute". I know it follows "tradition", but we are trying to
> > > > fix that at the moment. Laptop micmute button is a laptop micmute
> > > > button, and userspace should not need to know what prefix to use
> > > > depending on vendor.
> > > > 
> > > > I'd suggest using "sys::micmute".
> > > 
> > > I can imagine that in future some devices like keyboards would have also
> > > mute led. We already have keyboards with mute key, so it is something
> > > not unrealistic. What should be name convention for these mute leds?
> > > 
> > > Is not "sys::" prefix too generic?
> > 
> > Good point.  I thought of "laptop::" but it's not always laptop.
> > "builtin::"?  Doesn't sound great, either.
> > 
> > A nice godfather is required here...
> 
> Just use sys:: :-).
> 
> laptop:: would work for me, too. (It is always laptop in the cases we
> are handling now, right?)

In theory, such a thing can be on all-in-one desktops, too.

> When we get a keyboard with mute led, we'll have to decide if it
> should be input6::mute -- because it is on keyboard, or if it is
> sys::mute -- because the key is expected to mute whole system.

OK, I'll wait for more comments in today and update accordingly.


thanks,

Takashi



[Index of Archives]     [Linux Kernel Development]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux