On 2018/11/26 21:06, YueHaibing wrote:
> Fix a static code checker warning:
> drivers/platform/x86/intel_ips.c:1314
> ips_debugfs_init() warn: passing zero to 'PTR_ERR'
> drivers/platform/x86/intel_ips.c:1328
> ips_debugfs_init() warn: passing zero to 'PTR_ERR'
>
> If error occurs,debugfs_create_dir/debugfs_create_file
> return NULL while debugfs is enabled, which should not
> passing to ERR_PTR.
Sorry, a typo 'ERR_PTR' should be 'PTR_ERR', will send v2.
>
> Fixes: aa7ffc01d254 ("x86 platform driver: intelligent power sharing driver")
> Signed-off-by: YueHaibing <yuehaibing@xxxxxxxxxx>
> ---
> drivers/platform/x86/intel_ips.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/platform/x86/intel_ips.c b/drivers/platform/x86/intel_ips.c
> index 225638a..a5d1a68 100644
> --- a/drivers/platform/x86/intel_ips.c
> +++ b/drivers/platform/x86/intel_ips.c
> @@ -1311,8 +1311,7 @@ static void ips_debugfs_init(struct ips_driver *ips)
>
> ips->debug_root = debugfs_create_dir("ips", NULL);
> if (!ips->debug_root) {
> - dev_err(ips->dev, "failed to create debugfs entries: %ld\n",
> - PTR_ERR(ips->debug_root));
> + dev_err(ips->dev, "failed to create debugfs entries\n")
> return;
> }
>
> @@ -1325,8 +1324,7 @@ static void ips_debugfs_init(struct ips_driver *ips)
> ips->debug_root, node,
> &ips_debugfs_ops);
> if (!ent) {
> - dev_err(ips->dev, "failed to create debug file: %ld\n",
> - PTR_ERR(ent));
> + dev_err(ips->dev, "failed to create debug file\n");
> goto err_cleanup;
> }
> }
>
