On Mon, Nov 19, 2018 at 04:22:54PM +0000, Jethro Beekman wrote: > On 2018-11-19 20:36, Jarkko Sakkinen wrote: > > Question: should be dissolve the driver completely and move this code to > > arch/x86/kernel/cpu/sgx/ (and rename intel_sgx.c as main.c)? Swapping > > patch removes the possibility to compile this as a module anyway. > > No. We should keep the capability to build this as a module for other users > of SGX. What is the swapping patch and why doesn't allow building as a > module? In some earlier version of the patch set the request was to remove the callback interface to the driver so now core does direct calls to the swapping operations. /Jarkko