On Thu, Nov 15, 2018 at 05:37:27PM -0800, Randy Dunlap wrote: > On 11/15/18 5:01 PM, Jarkko Sakkinen wrote: > > Intel Software Guard eXtensions (SGX) is a set of CPU instructions that > > can be used by applications to set aside private regions of code and > > data. The code outside the enclave is disallowed to access the memory > > inside the enclave by the CPU access control. > > > > SGX driver provides a ioctl API for loading and initializing enclaves. > > Address range for enclaves is reserved with mmap() and they are > > destroyed with munmap(). Enclave construction, measurement and > > initialization is done with the provided the ioctl API. > > > > Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@xxxxxxxxxxxxxxx> > > Co-developed-by: Sean Christopherson <sean.j.christopherson@xxxxxxxxx> > > Signed-off-by: Sean Christopherson <sean.j.christopherson@xxxxxxxxx> > > Co-developed-by: Serge Ayoun <serge.ayoun@xxxxxxxxx> > > Signed-off-by: Serge Ayoun <serge.ayoun@xxxxxxxxx> > > Co-developed-by: Shay Katz-zamir <shay.katz-zamir@xxxxxxxxx> > > Signed-off-by: Shay Katz-zamir <shay.katz-zamir@xxxxxxxxx> > > Co-developed-by: Suresh Siddha <suresh.b.siddha@xxxxxxxxx> > > Signed-off-by: Suresh Siddha <suresh.b.siddha@xxxxxxxxx> > > --- > > > diff --git a/arch/x86/include/uapi/asm/sgx.h b/arch/x86/include/uapi/asm/sgx.h > > new file mode 100644 > > index 000000000000..aadf9c76e360 > > --- /dev/null > > +++ b/arch/x86/include/uapi/asm/sgx.h > > @@ -0,0 +1,59 @@ > > +/* SPDX-License-Identifier: (GPL-2.0 OR BSD-3-Clause) */ > > +/** > > + * Copyright(c) 2016-18 Intel Corporation. > > + */ > > +#ifndef _UAPI_ASM_X86_SGX_H > > +#define _UAPI_ASM_X86_SGX_H > > + > > +#include <linux/types.h> > > +#include <linux/ioctl.h> > > + > > +#define SGX_MAGIC 0xA4 > > + > > +#define SGX_IOC_ENCLAVE_CREATE \ > > + _IOW(SGX_MAGIC, 0x00, struct sgx_enclave_create) > > +#define SGX_IOC_ENCLAVE_ADD_PAGE \ > > + _IOW(SGX_MAGIC, 0x01, struct sgx_enclave_add_page) > > +#define SGX_IOC_ENCLAVE_INIT \ > > + _IOW(SGX_MAGIC, 0x02, struct sgx_enclave_init) > > + > > +/* IOCTL return values */ > > +#define SGX_POWER_LOST_ENCLAVE 0x40000000 > > > Hi, > The ioctl magic number should be documented in > Documentation/ioctl/ioctl-number.txt. > > ta. > -- > ~Randy Thank you. Addressed now in https://github.com/jsakkine-intel/linux-sgx.git. /Jarkko
