> -----Original Message----- > From: Andy Shevchenko <andy.shevchenko@xxxxxxxxx> > Sent: Tuesday, November 13, 2018 5:26 PM > To: Vadim Pasternak <vadimp@xxxxxxxxxxxx> > Cc: Darren Hart <dvhart@xxxxxxxxxxxxx>; Platform Driver <platform-driver- > x86@xxxxxxxxxxxxxxx>; Jiří Pírko <jiri@xxxxxxxxxxx>; Michael Shych > <michaelsh@xxxxxxxxxxxx> > Subject: Re: [PATCH platform-next v1 4/7] platform/x86: mlx-platform: Fix LED > configuration > > On Tue, Nov 13, 2018 at 3:55 PM Vadim Pasternak <vadimp@xxxxxxxxxxxx> > wrote: > > > > Exchange LED configuration between msn201x and next generation systems > > types. > > Why? Just my bug. I missed it. > > > > > Fixes: 1189456b1cce ("platform/x86: mlx-platform: Add LED platform > > driver activation") > > Signed-off-by: Vadim Pasternak <vadimp@xxxxxxxxxxxx> > > --- > > drivers/platform/x86/mlx-platform.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/platform/x86/mlx-platform.c > > b/drivers/platform/x86/mlx-platform.c > > index 7e92264..750b153 100644 > > --- a/drivers/platform/x86/mlx-platform.c > > +++ b/drivers/platform/x86/mlx-platform.c > > @@ -1430,7 +1430,7 @@ static int __init > mlxplat_dmi_msn201x_matched(const struct dmi_system_id *dmi) > > mlxplat_hotplug = &mlxplat_mlxcpld_msn201x_data; > > mlxplat_hotplug->deferred_nr = > > mlxplat_default_channels[i - 1][MLXPLAT_CPLD_GRP_CHNL_NUM - > 1]; > > - mlxplat_led = &mlxplat_default_ng_led_data; > > + mlxplat_led = &mlxplat_msn21xx_led_data; > > mlxplat_regs_io = &mlxplat_msn21xx_regs_io_data; > > > > return 1; > > @@ -1448,7 +1448,7 @@ static int __init > mlxplat_dmi_qmb7xx_matched(const struct dmi_system_id *dmi) > > mlxplat_hotplug = &mlxplat_mlxcpld_default_ng_data; > > mlxplat_hotplug->deferred_nr = > > mlxplat_msn21xx_channels[MLXPLAT_CPLD_GRP_CHNL_NUM - 1]; > > - mlxplat_led = &mlxplat_msn21xx_led_data; > > + mlxplat_led = &mlxplat_default_ng_led_data; > > mlxplat_fan = &mlxplat_default_fan_data; > > > > return 1; > > -- > > 2.1.4 > > > > > -- > With Best Regards, > Andy Shevchenko