On Thu, Nov 08, 2018 at 04:39:42PM +0200, Jarkko Sakkinen wrote: > On Wed, Nov 07, 2018 at 09:09:37AM -0800, Dave Hansen wrote: > > On 11/7/18 8:30 AM, Jarkko Sakkinen wrote: > > >> Does this code run when I type "make kselftest"? If not, I think we > > >> should rectify that. > > > No, it doesn't. It is just my backup for the non-SDK user space code > > > that I've made that I will use to fork my user space SGX projects in > > > the future. > > > > > > I can work-out a selftest (and provide a new patch in the series) but > > > I'm still wondering what the enclave should do. I would suggest that > > > we start with an enclave that does just EEXIT and nothing else. > > > > Yeah, that's a start. But, a good selftest would include things like > > faults and error conditions. > > Great. We can add more entry points to the enclave for different tests > but I'll start with a bare minimum. And yeah but ever goes into next > version I'll document the fault handling. For the v17 I'll add exactly two test cases: 1. EENTER/EEXIT 2. EENTER/exception So that it will easier to evaluate and demonstrate exception handling. /Jarkko
