On Sat, Nov 03, 2018 at 03:15:15PM +0200, Andy Shevchenko wrote: > > @@ -618,6 +618,8 @@ static void detect_sgx(struct cpuinfo_x86 *c) > > setup_clear_cpu_cap(X86_FEATURE_SGX1); > > setup_clear_cpu_cap(X86_FEATURE_SGX2); > > } > > + if (unsupported || !(fc & FEATURE_CONTROL_SGX_LE_WR)) > > + setup_clear_cpu_cap(X86_FEATURE_SGX_LC); > > } > > A-ha, I see how you use this variable here (though it's still possible > to get rid of it, choose what is better for readability / > maintenance). I would propose to squash this one to the earlier commit and refactor it in a way that I proposed. Having this part as a separate commit in my opinion is a bit confusing. /Jarkko
