On Fri, Nov 2, 2018 at 12:37 PM Rajneesh Bhardwaj <rajneesh.bhardwaj@xxxxxxxxxxxxxxx> wrote: > > The LTR values follow PCIE LTR encoding format and can be decoded as per > https://pcisig.com/sites/default/files/specification_documents/ECN_LatencyTolnReporting_14Aug08.pdf > > This adds support to translate the raw LTR values as read from the PMC > to meaningful values in nanosecond units of time. > +#include <linux/bits.h> I told you something different, i.e. put this header where you _use_ it, i.o.w into the header file. > +#define LTR_REQ_NONSNOOP BIT(31) > +#define LTR_REQ_SNOOP BIT(15) > +#define LTR_DECODED_VAL GENMASK(9, 0) > +#define LTR_DECODED_SCALE GENMASK(12, 10) If these are in one register, please keep ordered by start bit. The rest is fine. -- With Best Regards, Andy Shevchenko
