On Thu, Nov 1, 2018 at 9:00 AM Peng Hao <peng.hao2@xxxxxxxxxx> wrote:
>
> use acpi_dev_resource_io API.
>
Same comments as per patch 1.
This should be patch 2/8 in the series.
Otherwise,
Reviewed-by: Andy Shevchenko <andy.shevchenko@xxxxxxxxx>
Also, you might consider to use Suggested-by tag here.
> Signed-off-by: Peng Hao <peng.hao2@xxxxxxxxxx>
> ---
> drivers/misc/pvpanic.c | 14 ++++++--------
> 1 file changed, 6 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/misc/pvpanic.c b/drivers/misc/pvpanic.c
> index 0bcf1cd..c20fdff 100644
> --- a/drivers/misc/pvpanic.c
> +++ b/drivers/misc/pvpanic.c
> @@ -64,17 +64,15 @@
> static acpi_status
> pvpanic_walk_resources(struct acpi_resource *res, void *context)
> {
> - switch (res->type) {
> - case ACPI_RESOURCE_TYPE_END_TAG:
> - return AE_OK;
> + struct resource r;
>
> - case ACPI_RESOURCE_TYPE_IO:
> - port = res->data.io.minimum;
> + if (acpi_dev_resource_io(res, &r)) {
> + port = r.start;
> return AE_OK;
> -
> - default:
> - return AE_ERROR;
> }
> +
> + return AE_ERROR;
> +
> }
>
> static int pvpanic_add(struct acpi_device *device)
> --
> 1.8.3.1
>
--
With Best Regards,
Andy Shevchenko
