On Sat, 27 Oct 2018, Milan Hauth wrote:
> move CONFIG_THINKPAD_ACPI_UNSAFE_LEDS compile config
> to thinkpad_acpi.unsafe_leds module parameter
>
> so there is no more need to re-compile
> to control important LEDs, which is unsafe
>
> Signed-off-by: Milan Hauth <milahu@xxxxxxxxx>
I am not confortable signing-off on this one.
That option is a compile-time config option with a warning for distros
to never enable it for a reason:
If you are going to enable it, you are to know what you are doing,
*and* the user is to be made aware of the fact that you did it.
Also, if you mess with those LEDs, IMO you'd better have something that
*does* warn the user when the kernel spills alert and emergency-level
messages to the kernel log, which is _not_ the default of some large-
userbase desktop environments out there. You have been warned.
--
Henrique Holschuh
