On Wed, Oct 24, 2018 at 12:02 PM Peng Hao <peng.hao2@xxxxxxxxxx> wrote:
>
> By default, when ACPI tables and FDT coexist for ARM64,
> current kernel takes precedence over FDT to get device information.
> This patch increases the way to get information through FDT.
> * pvpanic.c - pvpanic Device Support
> *
> * Copyright (C) 2013 Fujitsu.
> + * Copyright (C) 2018 ZTE.
> *
> * This program is free software; you can redistribute it and/or modify
> * it under the terms of the GNU General Public License as published by
This hunk would be a separate patch which includes switch to SPDX and
removing the file name from the file itself.
> @@ -25,6 +26,10 @@
> #include <linux/init.h>
> #include <linux/types.h>
> #include <linux/acpi.h>
> +#include <linux/of.h>
> +#include <linux/of_address.h>
> +#include <asm/virt.h>
asm/* goes after linux/*
> +#include <linux/platform_device.h>
Better to keep sorted.
> + if (!mem)
> + return -EINVAL;
> +
> + if (!devm_request_mem_region(&pdev->dev, mem->start,
> + resource_size(mem), pdev->name))
> + return -EBUSY;
> +
> + base = devm_ioremap(&pdev->dev, mem->start,
> + resource_size(mem));
> + if (base == NULL)
> + return -EFAULT;
devm_ioremap_resource()
> +static const struct of_device_id pvpanic_mmio_match[] = {
> + { .compatible = "qemu,pvpanic-mmio", },
> + {},
terminators better w/o comma.
> +};
--
With Best Regards,
Andy Shevchenko
