On Fri, 2018-10-19 at 16:57 +0300, Andy Shevchenko wrote: > On Wed, Oct 10, 2018 at 8:23 PM Lubomir Rintel <lkundrak@xxxxx> wrote: > > Hi. > > > > This patchset adds support for the Embedded Controller on an OLPC XO > > 1.75 machine. OLPC XO 1.75 is a MMP2 based ARM laptop. It plugs into > > the existing OLPC platform infrastructure, currently used by the x86 > > based models. > > > > The EC operates in SPI master mode, meaning the SOC is the SPI slave. It > > uses extra handshake signal to signal readiness of SOC to accept data > > from EC and to initiate a transaction if SOC wishes to submit data. > > > > The SPI slave support for MMP2 was submitted separately: > > https://lore.kernel.org/lkml/20181010170936.316862-1-lkundrak@xxxxx/T/#t > > > > THe "power: supply: olpc_battery: correct the temperature" patch was > > The > > > already sent out separately, but I'm including it because the last > > commit of the set depends on it. > > > > Tested to work on an OLPC XO 1.75 and also tested not to break x86 > > support with an OLPC XO 1 machine. I don't have a XO 1.5, but it's > > unlikely this breaks it when XO 1 works. > > > > Thanks in advance for reviews and feedback of any kind. > > Thanks for the series. > I'm about to review the patch 6, otherwise read my comments for the > rest and consider addressing them. Thank you very much for your feedback, it is very appreciated. The XO 1.75 patch set has grown somewhat larger than I'm comfortable with, so I need some time to digest and address the review. I hope I'll be able to post a v2 some time after the 4.20 merge window closes and respond to questions raised in individual patches before that. > > > Lubo > > > >