On Wed, 2018-10-03 at 11:00 +0300, Andy Shevchenko wrote:
> On Sat, Sep 29, 2018 at 12:54 AM Joe Perches <joe@xxxxxxxxxxx> wrote:
> > Please fix this defect appropriately.
> >
> > linux-next MAINTAINERS section:
> >
> > 7441 INTEL PMC CORE DRIVER
> > 7442 M: Rajneesh Bhardwaj <rajneesh.bhardwaj@xxxxxxxxx>
> > 7443 M: Vishwanath Somayaji <vishwanath.somayaji@xxxxxxxxx>
> > 7444 L: platform-driver-x86@xxxxxxxxxxxxxxx
> > 7445 S: Maintained
> > --> 7446 F: arch/x86/include/asm/pmc_core.h
> > 7447 F: drivers/platform/x86/intel_pmc_core*
> >
> > Commit that introduced this:
>
> This is strange the shuffle of the MAINTAINERS based on the script is
> a culprit of the above inconsistency.
>
> Btw, I run parse-maintainers.pl against it and there are a lot more
> "unsorted" lines.
> What Linus or me or both did miss?
Nothing really.
The script used git-blame on the specific line, that's all.
There is no simple way to actually find a specific
commit that adds a particular line to a file if there is
any refactoring done to the file after it was added.
commit b740d2e9233cb33626d3b62210bcfc6a34baa839
Author: Rajneesh Bhardwaj <rajneesh.bhardwaj@xxxxxxxxx>
Date: Thu May 26 14:41:19 2016 +0530
platform/x86: Add PMC Driver for Intel Core SoC
Anyway, the real cause of the file pattern being unused
was also written below:
> > Last commit with arch/x86/include/asm/pmc_core.h
> >
> > commit 941691ef2197944a202d7870dcd7da3fb0391c65
> > Author: Rajneesh Bhardwaj <rajneesh.bhardwaj@xxxxxxxxx>
> > Date: Wed Jan 31 11:50:22 2018 +0530
> >
> > platform/x86: intel_pmc_core: Remove unused header file
> >
> > Recently sent patch 'platform/x86: intel_pmc_core: Remove unused EXPORTED
> > API' missed to remove the header file 'arch/x86/include/asm/pmc_core.h'
> > which was solely used to declare the EXPORTED API
> > 'intel_pmc_slp_s0_counter_read'. This patch provides the errata fix for the
> > same.
> >
> > Signed-off-by: Rajneesh Bhardwaj <rajneesh.bhardwaj@xxxxxxxxx>
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> >
> > arch/x86/include/asm/pmc_core.h | 27 ---------------------------
> > drivers/platform/x86/intel_pmc_core.c | 1 -
> > 2 files changed, 28 deletions(-)
>
