Hi, 21. September 2018 03:45, "Paul Gortmaker" <paul.gortmaker@xxxxxxxxxxxxx> schrieb: > I came across this older netbook over the xmas holidays, and noticed the > acerhdf driver wouldn't load. Turns out the BIOS string was too new, > and not listed in the driver. There were module params for overrides, > but I found their use isn't quite clear without reading the source. > > Here I clarify some of the module parameter usage, and then add the new > BIOS string, so they won't be needed for this particular platform. Some > probe code is also shifted out to be __init to reduce the driver size a > bit. Further details can be found in the respective commit logs. > > Since it was months ago when I created these patches, I retested on top > of tree to ensure things still work, as can be seen below. Thanks a lot for your work and this set of changes. This improves quality. I reviewed all 6 patches. Reviewed-by: Peter Feuerer <peter@xxxxxxxx> Please also add CC: Boris Petkov <bp@xxxxxxx> for review. [...] -- kind regards, --peter;