On Fri, 07 Sep 2018, Yves-Alexis Perez wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA256 > > On Fri, 2018-09-07 at 19:59 +0200, Thomas Weißschuh wrote: > > > was this included in any tree and is it on route to Linus somehow? > > > > This is on track to be released in 4.19. > > Thanks. I've applied the three patches (this one and the two from Jouke) on > top of 4.18.6 and I confirm I can set the thresholds on BAT1. > > > > > My ThinkPad X250 has two batteries and I can only configure threshold on BAT0, > > > and I guess it's because of this, so it'd be nice to have it fixed (and maybe > > > backported to relevant stable kernels). > > > > As far as I know only changes that fix behaviour that worked before are > > eligible for stable. As this specific functionality never worked before I > > figured it would be moot to also send it to stable. > > Well, it does somehow work when you have one battery, but it's really > frustrating to have it not work for the second one. > > > > (If it is fine to send stuff like this to stable, we could try, though) > > Indeed, not sure if “frustrating” is reason enough for stable :) FWIW, once given enough testing, yes, I think this should be proposed for -stable. -- Henrique Holschuh
