On Mon, Sep 03, 2018 at 11:45:14PM +0000, Huang, Kai wrote: > But INVALID_TOKEN is not only returned when MSRs are mismatched, so do > you plan to check to rule out other cases that cause INVALID_TOKEN > before retrying EINIT, or unconditionally retry EINIT? And we should > only retry once? In the case of this error we will do wrmsrs and retry einit once. This is how I understood it at least. Q: Do we have to care about VMM sleep anyway? I mean if VMM always traps EINIT it can write the MSRs with guest values if it has been sleeping. If the answer is no, then retrying once should be a complete solution and we don't need pm_cnt. /Jarkko
