On Sun, Aug 5, 2018 at 3:18 AM, Gustavo A. R. Silva <gustavo@xxxxxxxxxxxxxx> wrote: > Return statements in functions returning bool should use true or false > instead of an integer value. > > This code was detected with the help of Coccinelle. > static bool has_cap(u32 cap) > { > if ((interface->capability & cap) != 0) > - return 1; > + return true; > > - return 0; > + return false; > } this entire function can be oneliner: return !!(...); -- With Best Regards, Andy Shevchenko