On Wed, Jul 11, 2018 at 2:06 PM Henrique de Moraes Holschuh <hmh@xxxxxxxxxx> wrote: > > On Wed, 11 Jul 2018, Jouke Witteveen wrote: > > Modern Thinkpads have three character model designators. Previously, they > > would be accepted, but recorded incompletely. Revision matching extracted > > the wrong bytes from the ID string. This made the use of quirks for modern > > machines impossible. > > > > Fixes: 1b0eb5bc2413 > > Signed-off-by: Jouke Witteveen <j.witteveen@xxxxxxxxx> > > In which thinkpad models did you test this? It would be interesting > to have that in the commit message, please. It needs to be tested on a > two-char and a three-char model. > > If necessary, I can test on a T43 if you don't have a two-char model > around, but that might take a few days. > I tested on a Thinkpad 13 (cf. the other patch). Unfortunately, I have no other Thinkpads available and indeed I did not test on any two-char models. A test on a T43 would be highly appreciated. In particular, it would be nice to test whether the quirks mechanism still functions correctly on the two-char models. I see that there are quirks for leds and brightness in place for the T43. Thanks, - Jouke
