On Thu, Jul 05, 2018 at 07:05:49PM +0300, Jarkko Sakkinen wrote: > On Tue, Jul 03, 2018 at 11:31:59AM -0700, Dave Hansen wrote: > > On 07/03/2018 11:19 AM, Jarkko Sakkinen wrote: > > > --- a/arch/x86/include/asm/msr-index.h > > > +++ b/arch/x86/include/asm/msr-index.h > > > @@ -479,6 +479,8 @@ > > > #define FEATURE_CONTROL_LOCKED (1<<0) > > > #define FEATURE_CONTROL_VMXON_ENABLED_INSIDE_SMX (1<<1) > > > #define FEATURE_CONTROL_VMXON_ENABLED_OUTSIDE_SMX (1<<2) > > > +#define FEATURE_CONTROL_SGX_ENABLE (1<<18) > > > +#define FEATURE_CONTROL_SGX_LE_WR (1<<17) > > > #define FEATURE_CONTROL_LMCE (1<<20) > > > > Have you run checkpatch.pl on these? There's a tabs-vs-spaces issue here. > > High portion of lines in this file are over 80 characters and have this > same incosistent spacing. I'm not sure if this should be fixed bacause > it would be consistent with the formatting that this file uses... Ignore! I was looking at the cpufeature patch, this one really has a formatting issue (apologies). /Jarkko