Re: [PATCH] platform/x86: asus-wireless: Toggle airplane mode LED

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jul 2, 2018 at 6:18 AM, Andy Shevchenko
<andy.shevchenko@xxxxxxxxx> wrote:
> On Sat, Jun 30, 2018 at 3:11 AM, João Paulo Rechi Vita
> <jprvita@xxxxxxxxx> wrote:
>> This commit makes use of a newly implemented RFKill LED trigger to
>> trigger the LED when all radios are blocked.
>>
>
> Pushed to my review and testing queue, thanks!
>
> P.S. Should it have Fixes tag and possible go to stable?
>

Thanks! I don't think this is stable material, as it is not preventing
any kernel crash or fixing any other serious bug, and it would also
need the "rfkill-none" led trigger to be backported with it.

Maybe you were actually referring to the other patch, "platform/x86:
asus-wireless: Fix uninitialized symbol usage"? If so, I'm not sure
what is the stable policy for that kind of fix: it addresses a real
problem that was detected through static analysis, but no occurrences
have been seen in the wild. I'll leave the decision of forwarding that
to stable or not to you.

Regards,

--
João Paulo Rechi Vita
http://about.me/jprvita




[Index of Archives]     [Linux Kernel Development]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux