Re: [platform-drivers-x86:review-dvhart 5/8] drivers/platform/x86/toshiba_acpi.c:3257:57: sparse: incompatible types for operation (==)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Jun 23, 2018 at 02:43:04PM +0800, kbuild test robot wrote:
> tree:   git://git.infradead.org/users/dvhart/linux-platform-drivers-x86.git review-dvhart
> head:   dc8ad7e387eb593dc5a3bddf78d630d99243728d
> commit: 79cd91bd841cd4de30efe2d46e26bd98016d635e [5/8] platform/x86: toshiba_acpi: Update KBD backlight LED on second gen laptops
> reproduce:
>         # apt-get install sparse
>         git checkout 79cd91bd841cd4de30efe2d46e26bd98016d635e
>         make ARCH=x86_64 allmodconfig
>         make C=1 CF=-D__CHECK_ENDIAN__
> 
> 
> sparse warnings: (new ones prefixed by >>)
> 
>    drivers/platform/x86/toshiba_acpi.c:1430:15: sparse: expression using sizeof(void)
>    drivers/platform/x86/toshiba_acpi.c:1614:15: sparse: expression using sizeof(void)
>    drivers/platform/x86/toshiba_acpi.c:1663:15: sparse: expression using sizeof(void)
> >> drivers/platform/x86/toshiba_acpi.c:3257:57: sparse: incompatible types for operation (==)
>    drivers/platform/x86/toshiba_acpi.c:3257:57:    left side has type int *<noident>
>    drivers/platform/x86/toshiba_acpi.c:3257:57:    right side has type int
> >> drivers/platform/x86/toshiba_acpi.c:3257:57: sparse: incorrect type in conditional
>    drivers/platform/x86/toshiba_acpi.c:3257:57:    got bad type
>    drivers/platform/x86/toshiba_acpi.c: In function 'toshiba_acpi_notify':
>    drivers/platform/x86/toshiba_acpi.c:3257:22: warning: comparison between pointer and integer
>          (&dev->kbd_mode == SCI_KBD_MODE_ON) ?

Azael,

This was a trivial fix, I've just taken care of it.

Thanks,
-- 
Darren Hart
VMware Open Source Technology Center



[Index of Archives]     [Linux Kernel Development]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux