On Fri, Jun 15, 2018 at 11:46:27AM -0600, Azael Avalos wrote: > Second generation keyboard backlight (type 2) laptops can switch > on the keyboard LED on their own via hardware/firmware, but the > LED subsystem is unaware of such change since the LED interface > was only being created on first generation keyboard backlight > (type 1) laptops. > > This patch creates the LED interface for second gen keyboards > and calls the *_hw_changed API whenever userspace changes the > state of the keyboard backlight LED. > > While we are at it, remove an unneeded asignment to the acpi_dev > struct under *_kbd_bl_work, and also update the kbd_event_generated > variable in the main toshiba struct instead of the global struct. > > Signed-off-by: Azael Avalos <coproscefalo@xxxxxxxxx> > --- > Changes since v1: > - Added notes to message commit about changes to variables > inside the main toshiba struct and the removal of an > unneeded acpi_dev variable > - Corrected small typo beign->being Thanks Azael, queued. Just a note re my comment on v1. I'm taking this patch because it improves the functionality of the driver and working within the existing structure. I would like to see if we can eliminate the duplicate toshiba structure as a follow on. -- Darren Hart VMware Open Source Technology Center
