On Tue, Jun 19, 2018 at 07:01:57AM -0700, Dave Hansen wrote: > On 06/19/2018 06:18 AM, Jarkko Sakkinen wrote: > > On Fri, Jun 08, 2018 at 10:25:29AM -0700, Dave Hansen wrote: > >> On 06/08/2018 10:09 AM, Jarkko Sakkinen wrote: > >>> Signed-off-by: Sean Christopherson <sean.j.christopherson@xxxxxxxxx> > >>> Signed-off-by: Haim Cohen <haim.cohen@xxxxxxxxx> > >>> Tested-by: Serge Ayoun <serge.ayoun@xxxxxxxxx> > >>> Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@xxxxxxxxxxxxxxx> > >>> Tested-by: Jarkko Sakkinen <jarkko.sakkinen@xxxxxxxxxxxxxxx> > >>> Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@xxxxxxxxxxxxxxx> > >> > >> These are a mess. If you're signing off on it, a review of some kind is > >> pretty implied. > >> > >> Also, how did Sean write this, send it to Haim to sign off on it, and > >> then send it to you? That seems unlikely. > > > > They've both done something to this. How should I change it then? > > Who added their Signed-off-by? > > I would probably add a single "Co-developed-by:" for each of them and a > single Signed-off-by, like commit 12c89130a56ae: > > Co-developed-by: Tony Luck <tony.luck@xxxxxxxxx> > Reported-by: Mika Penttilä <mika.penttila@xxxxxxxxxxxx> > Signed-off-by: Dan Williams <dan.j.williams@xxxxxxxxx> > Cc: Al Viro <viro@xxxxxxxxxxxxxxxxxx> > Cc: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> > Cc: Andy Lutomirski <luto@xxxxxxxxxxxxxx> > ... Thanks, I was not aware of that tag. /Jarkko
